CAUS-2: write CausalImpact shock-based estimator #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, Ingrid! Ask questions and make comments here, and we can get this thing in there. Try to keep each PR to under 200 lines ... if it's getting longer, we'll merge it in and start a new logical addition. |
akelleh
changed the title
|
Hey Ingrid! Just checking in! lmk if you have any questions, and don't forget to keep your PR up to date, even if it's a total work in progress! |
|
Yeah --- i plan on working on it this weekend! I just havent even started yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 didn't like the empty spaces in the file after some of the lines.