Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): Improve Github actions tests #681

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CharlesJUDITH
Copy link
Contributor

Usually there's one PR per project/chain and all the chains are tested while the PR is open. This PR aims to detect the project/chain that has been changed and just run the test for that specific chain/project.

Usually there's one PR per project/chain and all the chains are tested while the PR is open.
This PR aims to detect the project/chain that has been changed and just run the test for that specific chain/project.
@CharlesJUDITH
Copy link
Contributor Author

@tombeynon
Copy link
Collaborator

@CharlesJUDITH this is awesome, thank you! I notice the build isn't named like it is with the current workflow. What happens if multiple chains are updated in the same PR?

@CharlesJUDITH
Copy link
Contributor Author

this is awesome, thank you! I notice the build isn't named like it is with the current workflow. What happens if multiple chains are updated in the same PR?

I saw that most of the time the chains are updated individually (1 change, 1 PR). I tested that use case but I can test for 2 or 3 changes in the sane PR it should work. Will test it and keep you posted here.

@tombeynon
Copy link
Collaborator

Thank you that would be great. You and I stick to one PR per chain but previously others have submitted multiple. We'll try and avoid that, but would be ideal if it can handle it

@pratikbin
Copy link
Contributor

pratikbin commented May 6, 2024

This will make CI really efficient. I was thinking of doing the same 24 hours ago and then I saw your PR. gg

@tombeynon tombeynon marked this pull request as draft November 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants