Fix DecCoin decoder to avoid absurdly large values #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtary
commented
Jul 14, 2022
| @@ -135,7 +135,7 @@ export const DecCoin = { | |||
| message.denom = reader.string(); | |||
| break; | |||
| case 2: | |||
| message.amount = reader.string(); | |||
| message.amount = (parseInt(reader.string()) / (10 ** 18)).toPrecision(18); | |||
There was a problem hiding this comment.
The actual meat-and-potatoes of this fix. Turns 2000000000000000000 into 2.000000000000000000.
flavioespinoza
approved these changes
Jul 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
Fix DecCoin decoder to avoid absurdly large values 0.1.1
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the decoder for DecCoins to convert the value into a decimal (as it should).
Note: This change modifies the decoder directly -- it does not fix the generator. If the protobufs are regenerated, this fix will need to be applied again. A unit test was added to check a regression does not occur.