Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cdx based oldest newest and near #159

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Conversation

akamhy
Copy link
Owner

@akamhy akamhy commented Feb 18, 2022

Availability API is too unreliable for use when compared with the CDX server API.

Merging this PR closes #155

…now cli uses the cdx methods instead of availablity api methods.
@pep8speaks
Copy link

pep8speaks commented Feb 18, 2022

Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 115:9: W503 line break before binary operator

Line 233:17: W503 line break before binary operator
Line 234:17: W503 line break before binary operator
Line 235:17: W503 line break before binary operator

Line 399:13: W503 line break before binary operator
Line 400:13: W503 line break before binary operator
Line 467:13: W503 line break before binary operator
Line 468:13: W503 line break before binary operator

Comment last updated at 2022-02-18 07:43:21 UTC

@akamhy akamhy added the enhancement New feature or request label Feb 18, 2022
@akamhy
Copy link
Owner Author

akamhy commented Feb 18, 2022

Hello @akamhy! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 233:17: W503 line break before binary operator
Line 234:17: W503 line break before binary operator
Line 235:17: W503 line break before binary operator

Line 399:13: W503 line break before binary operator
Line 400:13: W503 line break before binary operator
Line 467:13: W503 line break before binary operator
Line 468:13: W503 line break before binary operator

WTH

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #159 (d6341aa) into master (f990b93) will increase coverage by 0.00%.
The diff coverage is 90.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   95.45%   95.46%           
=======================================
  Files          10       10           
  Lines         638      661   +23     
=======================================
+ Hits          609      631   +22     
- Misses         29       30    +1     
Impacted Files Coverage Δ
waybackpy/cli.py 94.64% <76.92%> (-0.66%) ⬇️
waybackpy/availability_api.py 98.64% <100.00%> (-0.11%) ⬇️
waybackpy/cdx_api.py 93.89% <100.00%> (+1.30%) ⬆️
waybackpy/cdx_snapshot.py 100.00% <100.00%> (ø)
waybackpy/exceptions.py 100.00% <100.00%> (ø)
waybackpy/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f990b93...d6341aa. Read the comment docs.

@akamhy akamhy merged commit 4b218d3 into master Feb 18, 2022
@akamhy akamhy deleted the cdx-based-oldest-newest-and-near branch February 18, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not implement newest, near and oldest for the CDX Server API as we have for the Availability API
2 participants