Add sort, use_pagination and closest #158

akamhy · 2022-02-17T18:01:29Z

closes #157

see https://nla.github.io/outbackcdx/api.html#operation/query sort takes string input which must be one of the follwoing: - default - closest - reverse This commit shall help in closing issue at #155

…bots.txt

…ites that are blocking wayback machine by their robots.txt policy

…e pagination API and lookup archive close to a timestamp respectively. And now to get out of infinte blank pages loop just check for two succesive black and not total two blank pages while using the CDX server API.

pep8speaks · 2022-02-17T18:13:06Z

Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file waybackpy/cdx_utils.py:

Line 54:9: W503 line break before binary operator
Line 55:9: W503 line break before binary operator

In the file waybackpy/cli.py:

Line 281:5: W503 line break before binary operator
Line 303:5: W503 line break before binary operator

codecov · 2022-02-17T18:52:35Z

Codecov Report

Merging #158 (e94da0c) into master (f63c6ad) will increase coverage by 1.21%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   94.24%   95.45%   +1.21%     
==========================================
  Files          10       10              
  Lines         608      638      +30     
==========================================
+ Hits          573      609      +36     
+ Misses         35       29       -6

Impacted Files	Coverage Δ
waybackpy/cdx_api.py	`92.59% <82.35%> (+2.39%)`	⬆️
waybackpy/cdx_utils.py	`96.29% <88.88%> (-2.15%)`	⬇️
waybackpy/cli.py	`95.29% <100.00%> (+0.17%)`	⬆️
waybackpy/exceptions.py	`100.00% <100.00%> (ø)`
waybackpy/wrapper.py	`92.53% <0.00%> (+8.95%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63c6ad...e94da0c. Read the comment docs.

akamhy added 7 commits February 17, 2022 12:08

add sort param support in CDX API class

b4adf4a

see https://nla.github.io/outbackcdx/api.html#operation/query sort takes string input which must be one of the follwoing: - default - closest - reverse This commit shall help in closing issue at #155

add BlockedSiteError for cases when archiving is blocked by site's ro…

faa97e5

…bots.txt

create check_for_blocked_site for handling the BlockedSiteError for s…

28f4b57

…ites that are blocking wayback machine by their robots.txt policy

added cli support for sort, use-pagination and closest

b541d8d

added tests

6cd9ae1

fix codeql warnings, nothing to worry about here.

4486123

akamhy added the enhancement New feature or request label Feb 17, 2022

fix save test for archive_url

e94da0c

akamhy merged commit f990b93 into master Feb 17, 2022

akamhy deleted the add-sort-in-cdx branch February 17, 2022 18:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sort, use_pagination and closest #158

Add sort, use_pagination and closest #158

akamhy commented Feb 17, 2022

pep8speaks commented Feb 17, 2022

codecov bot commented Feb 17, 2022

Add sort, use_pagination and closest #158

Add sort, use_pagination and closest #158

Conversation

akamhy commented Feb 17, 2022

pep8speaks commented Feb 17, 2022

codecov bot commented Feb 17, 2022

Codecov Report