Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format and lint codes and fix packaging #125

Merged
merged 14 commits into from
Feb 3, 2022
Merged

Format and lint codes and fix packaging #125

merged 14 commits into from
Feb 3, 2022

Conversation

eggplants
Copy link
Collaborator

  • format codes with isort and black8
  • move package info in setup.py into setup.cfg
  • fix flake8 errors
  • merge __version__.py into __init__.py

@eggplants eggplants marked this pull request as draft February 3, 2022 12:52
@eggplants eggplants marked this pull request as ready for review February 3, 2022 13:09
@eggplants
Copy link
Collaborator Author

eggplants commented Feb 3, 2022 •
edited
Loading

When you merge this PR, please use squash-merge.
(Too many commits...)

@eggplants eggplants requested a review from akamhy February 3, 2022 13:11
@akamhy akamhy mentioned this pull request Feb 3, 2022
Closed
@eggplants eggplants mentioned this pull request Feb 3, 2022
Closed
akamhy
akamhy approved these changes Feb 3, 2022
View reviewed changes
Copy link
Owner

@akamhy akamhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akamhy
Copy link
Owner

akamhy commented Feb 3, 2022

closes #126

@akamhy akamhy linked an issue Feb 3, 2022 that may be closed by this pull request
Drop Python<=3.6 #126
Closed
@akamhy akamhy merged commit e61447e into akamhy:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akamhy akamhy akamhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python<=3.6
2 participants
@eggplants @akamhy