Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save retry mechanism #124

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Fix save retry mechanism #124

merged 1 commit into from
Feb 3, 2022

Conversation

eggplants
Copy link
Collaborator

@eggplants eggplants commented Feb 3, 2022

WaybackMachineSaveAPI.save raises AttributeError: 'WaybackMachineSaveAPI' object has no attribute 'response_url' when max_tries < 1.

$ pip show waybackpy
Name: waybackpy
Version: 3.0.2
Summary: Python package that interfaces with the Internet Archive's Wayback Machine APIs. Archive pages and retrieve archived pages easily.
Home-page: https://akamhy.github.io/waybackpy/
Author: Akash Mahanty
Author-email: [email protected]
License: MIT
Location: /Users/eggplants/.pyenv/versions/3.9.9/lib/python3.9/site-packages
Requires: click, requests
Required-by: wbsv
$ python -c 'import waybackpy;waybackpy.WaybackMachineSaveAPI("https://google.co.jp", max_tries=0).save()'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/eggplants/.pyenv/versions/3.9.9/lib/python3.9/site-packages/waybackpy/save_api.py", line 170, in save
    % (self.url, self.response_url, str(self.headers)),
AttributeError: 'WaybackMachineSaveAPI' object has no attribute 'response_url'

@akamhy akamhy merged commit 947647f into akamhy:master Feb 3, 2022
@eggplants eggplants deleted the fix_save_retry branch February 3, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants