Respect isort's skip_glob setting
#751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ranelpadon I started by successfully adding a failing unit test. Next, looking deeper into the reason for the wrong behavior. It's somehow related to the fact that Darker calls I invited you as a collaborator on this repository, hoping you could be the reviewer for this PR. Would you have time for that? |
|
Ok @ranelpadon there seem to be two reasons for
Reason 1. is easily fixed, but 2. is a trickier one. I'll need to spend a little more time on it. |
- `relative_path`: path relative to a `root` directory - `path_from_cwd`: either relative to working directory or an absolute path
akaihola
force-pushed
the
isort-skip-glob
branch
from
752da52
to
fa1a0f2
Compare
|
Not so difficult to fix after all. @ranelpadon could you verify that this branch works for you? This PR is best reviewed one commit at a time. |
akaihola
modified the milestones:
Darker 3.0.1,
Darker 3.0.0 - Backwards incompatible changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615.