-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH action to respect working-directory
#591
base: master
Are you sure you want to change the base?
Conversation
f78011c
to
9626dd8
Compare
f2d8c1d
to
7003e2a
Compare
3278010
to
12e99aa
Compare
@dshemetov this one is finally ready for review and validation! The |
630ae4e
to
2b486a6
Compare
2b486a6
to
bf1d6af
Compare
3f3b986
to
ad115b9
Compare
2e1cd5d
to
dcd00c5
Compare
I'm still hoping for extra eyeballs for this one. Sorry for adding quite a bit of mechanics necessary for testing this feature. Let me know if more comments or supporting documentation is required. This may be easier to review commit by commit than the whole diff at once. Ping @dshemetov @Svenito @dwt @MatthijsBurgh whichever one of you may be able to spare some time on reviewing. |
dcd00c5
to
4e6f897
Compare
Now rebased on |
Sorry, I don't have time for this one |
- change to working directory - install `pip-requirements-parser` in a separate step - include Darker exit code in outputs - include Darker standard output in outputs - run `commit-range` action locally - caching of the virtualenv and pip downloads
4e6f897
to
a43e398
Compare
a43e398
to
eb0e095
Compare
Still looking for a reviewer for this PR. You seem to have the ball rolling @clintonsteiner (thanks for all the effort!), would you be interested to look at this change to the GitHub action as well? |
🟠 Pending review is delaying Darker 3.0.0 release.
This patch introduces the following changes to the Darker GitHub Action:
working-directory
input option (defined inaction.yml
)exitcode
andstdout
outputs, and Python helpers for setting themcommit-range
action straight from the current Darker Git checkoutpip-requirements-parser
in a separate action step instead of the entrypoint scriptworking-directory
doesn't existpip install
into a helper functionversion
starts with@
(pointing to a branch or tag)working-directory
stdout
outputworking-directory
test workflowFIxes #587
Goes into Darker 3.0.0 since exit codes will need to change in a backwards incompatible way.