Skip to content

Commit

Permalink
logictest: use deterministic ID generation in tenants
Browse files Browse the repository at this point in the history
In cockroachdb#85366, we introduced a mechanism to make descriptor ID generation
transactional and, in the absence of parallelism, deterministic. That PR
failed to set the knob for secondary tenant configurations. This commit
rectifies that oversight.

This should allow us to avoid flakes like:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_GitHubCiOptional/5939930?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

Release note: None
  • Loading branch information
ajwerner committed Aug 2, 2022
1 parent 748b89a commit a476310
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/sql/logictest/logic.go
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,8 @@ func (t *logicTest) newCluster(
AllowSettingClusterSettings: true,
TestingKnobs: base.TestingKnobs{
SQLExecutor: &sql.ExecutorTestingKnobs{
DeterministicExplain: true,
DeterministicExplain: true,
UseTransactionalDescIDGenerator: true,
},
SQLStatsKnobs: &sqlstats.TestingKnobs{
AOSTClause: "AS OF SYSTEM TIME '-1us'",
Expand Down

0 comments on commit a476310

Please sign in to comment.