forked from cockroachdb/cockroach
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
39052: opt: compute join output col map properly r=justinj a=justinj Fixes cockroachdb#39010. This manifested with the advent of WITH, but the problem was actually that we were computing a join output map somewhat incorrectly. This never actually caused problems before because we would prune any columns that could cause there to be a disparity between the two ways of computing the size of the ColMap, but since WITH doesn't support pruning, it caused issues. I also replaced some other uses of Len that were potentially sketchy. Release note: None Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
- Loading branch information
Showing
2 changed files
with
51 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters