Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ValidationError and MissingRefError #1840

Closed
wants to merge 5 commits into from

Conversation

Ginden
Copy link

@Ginden Ginden commented Dec 10, 2021

What issue does this pull request resolve?

#1832

What changes did you make?

Exported 2 Error subclasses.

Is there anything that requires more attention while reviewing?

@epoberezkin
Copy link
Member

Never saw this export format before :)

It should be added in other ajv classes too - core.ts, jtd.ts, 2019.ts and 2020.ts

@epoberezkin
Copy link
Member

Probably no need to export from core.ts.

lib/ajv.ts Outdated Show resolved Hide resolved
@dannyb648
Copy link
Contributor

What is required to get this over the line? Im hitting alot of issues trying to upgrade a codebase. Happy to get involved if possible

@epoberezkin
Copy link
Member

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

@dannyb648
Copy link
Contributor

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

I've added these changes and the original ones to PR #2020 - Any chance of a review? Additionally looks like something is broken with the coverage plugin on all the PRs atm?

kodiakhq bot referenced this pull request in X-oss-byte/Canary-nextjs Sep 26, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ajv](https://ajv.js.org) ([source](https://togithub.com/ajv-validator/ajv)) | [`8.11.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/ajv/8.11.0/8.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>ajv-validator/ajv (ajv)</summary>

### [`v8.12.0`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.12.0)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.2...v8.12.0)

-   fix JTD serialisation (remove leading comma in objects with only optional properties) ([#&#8203;2190](https://togithub.com/ajv-validator/ajv/issues/2190), [@&#8203;piliugin-anton](https://togithub.com/piliugin-anton))
-   empty JTD "values" schema ([#&#8203;2191](https://togithub.com/ajv-validator/ajv/issues/2191))
-   empty object to work with JTD utility type ([#&#8203;2158](https://togithub.com/ajv-validator/ajv/issues/2158), [@&#8203;erikbrinkman](https://togithub.com/erikbrinkman))
-   fix JTD "discriminator" schema for objects with more than 8 properties ([#&#8203;2194](https://togithub.com/ajv-validator/ajv/issues/2194))
-   correctly narrow "number" type to "integer" ([#&#8203;2192](https://togithub.com/ajv-validator/ajv/issues/2192), [@&#8203;JacobLey](https://togithub.com/JacobLey))
-   update Node.js versions in CI to 14, 16, 18 and 19

### [`v8.11.2`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.2)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.1...v8.11.2)

Update dependencies

Export ValidationError and MissingRefError ([https://github.com/ajv-validator/ajv/pull/1840](https://togithub.com/ajv-validator/ajv/pull/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

### [`v8.11.1`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.1)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.0...v8.11.1)

Update dependencies

Export ValidationError and MissingRefError ([#&#8203;1840](https://togithub.com/ajv-validator/ajv/issues/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot referenced this pull request in X-oss-byte/Nextjs Sep 30, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ajv](https://ajv.js.org) ([source](https://togithub.com/ajv-validator/ajv)) | [`8.11.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/ajv/8.11.0/8.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ajv/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ajv/8.11.0/8.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>ajv-validator/ajv (ajv)</summary>

### [`v8.12.0`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.12.0)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.2...v8.12.0)

-   fix JTD serialisation (remove leading comma in objects with only optional properties) ([#&#8203;2190](https://togithub.com/ajv-validator/ajv/issues/2190), [@&#8203;piliugin-anton](https://togithub.com/piliugin-anton))
-   empty JTD "values" schema ([#&#8203;2191](https://togithub.com/ajv-validator/ajv/issues/2191))
-   empty object to work with JTD utility type ([#&#8203;2158](https://togithub.com/ajv-validator/ajv/issues/2158), [@&#8203;erikbrinkman](https://togithub.com/erikbrinkman))
-   fix JTD "discriminator" schema for objects with more than 8 properties ([#&#8203;2194](https://togithub.com/ajv-validator/ajv/issues/2194))
-   correctly narrow "number" type to "integer" ([#&#8203;2192](https://togithub.com/ajv-validator/ajv/issues/2192), [@&#8203;JacobLey](https://togithub.com/JacobLey))
-   update Node.js versions in CI to 14, 16, 18 and 19

### [`v8.11.2`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.2)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.1...v8.11.2)

Update dependencies

Export ValidationError and MissingRefError ([https://github.com/ajv-validator/ajv/pull/1840](https://togithub.com/ajv-validator/ajv/pull/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

### [`v8.11.1`](https://togithub.com/ajv-validator/ajv/releases/tag/v8.11.1)

[Compare Source](https://togithub.com/ajv-validator/ajv/compare/v8.11.0...v8.11.1)

Update dependencies

Export ValidationError and MissingRefError ([#&#8203;1840](https://togithub.com/ajv-validator/ajv/issues/1840), [@&#8203;dannyb648](https://togithub.com/dannyb648))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants