New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom webhooks #118

Merged

ajayyy merged 28 commits into ajayyy:master from TAG-Epic:custom-webhooks

Aug 29, 2020

Contributor

TAG-Epic commented Aug 23, 2020

No description provided.

TAG-Epic added 5 commits

August 23, 2020 19:42


          Add custom webhooks for votes

f7d162b


          Merge remote-tracking branch 'origin/master' into master

81cb93d


          Fix merge conflicts

2ffed72


          Use logger instead of console.log

77d08d2


          Update example & test config

a268f9a

ajayyy requested changes

View reviewed changes

Owner

ajayyy left a comment

Looks good. Maybe this stuff can be moved into a separate function to not clog up the vote function.

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

Joe-Dowd suggested changes

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

Joe-Dowd reviewed

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

TAG-Epic added 3 commits

August 23, 2020 21:44


          Refactor custom webhooks

e5aa631


          Change submission id to UUID

7ae97e4


          Update user status to include self remove

2597a57

ajayyy reviewed

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved


          Remove duplicate isOwnSubmission

14a990f

ajayyy reviewed

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved


          Fix missing semicolon

20d813d

Joe-Dowd reviewed

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

Joe-Dowd reviewed

View reviewed changes

src/routes/voteOnSponsorTime.js Outdated Show resolved Hide resolved

src/utils/dispatchWebhooks.js Outdated Show resolved Hide resolved

TAG-Epic added 3 commits

August 23, 2020 22:30


          Move getVoteAuthor to webhookUtils and move user status (api) to webh…

9eddc33

…ookUtils


          Remove broken and unnecessary check

a897c31


          Change .size to .length

16777c3

TAG-Epic requested a review from ajayyy

August 23, 2020 20:35

ajayyy reviewed

View reviewed changes

src/utils/dispatchWebhooks.js Outdated Show resolved Hide resolved

ajayyy reviewed

View reviewed changes

src/utils/webhookUtils.js Outdated Show resolved Hide resolved

TAG-Epic added 2 commits

August 24, 2020 09:06


          Move dispatchEvent to webhookUtils

aca4318


          Add webhooks to postSkipSegments

2c70f87

TAG-Epic requested a review from ajayyy

August 24, 2020 11:53


          Cleaned up function names

5c9aa8c

Joe-Dowd suggested changes

View reviewed changes

config.json.example Show resolved Hide resolved

src/routes/postSkipSegments.js Outdated Show resolved Hide resolved

TAG-Epic and others added 2 commits

August 24, 2020 22:45


          Remove random s

3085b0e


          make tests hit webhook code

75a62a5

Epic and others added 2 commits

August 24, 2020 23:06


          Merge pull request #1 from Joe-Dowd/testing-custom-webhooks

72b3173

make tests hit webhook code


          added failed webhook call to tests

3066a07

ajayyy approved these changes

View reviewed changes

TAG-Epic and others added 5 commits

August 24, 2020 23:14


          Merge pull request #2 from Joe-Dowd/testing-custom-webhooks

2dc5dea

added failed webhook call to tests


          add unresolvable host test - introduces tets faiulure

eb9282c


          Merge pull request #3 from Joe-Dowd/testing-custom-webhooks

ec1a294

add unresolvable host test - introduces tets faiulure


          Fixed undesolved test error


          tidy undesolved fix

dc7dadd

Contributor

Joe-Dowd commented Aug 24, 2020

Joe-Dowd and others added 2 commits

August 24, 2020 22:50


          added wrong port test

83ec232


          Merge pull request #4 from Joe-Dowd/testing-custom-webhooks

f7ea706

Fixed undesolved test error

TAG-Epic marked this pull request as ready for review

August 26, 2020 07:55

Owner

ajayyy commented Aug 27, 2020

Could the webhooks be moved to being sent after the server has sent a response code?


          Send webhooks after response

800a3df

ajayyy merged commit a161316 into ajayyy:master

ajayyy mentioned this pull request

Bounty: Public database syncing system (150$) #373

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet