fix: update JSX mode to reflect React JSX #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5451 +/- ##
==========================================
+ Coverage 87.60% 87.62% +0.01%
==========================================
Files 584 583 -1
Lines 46463 46418 -45
Branches 7023 7015 -8
==========================================
- Hits 40705 40674 -31
+ Misses 5758 5744 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whazor
approved these changes
Jan 8, 2024
|
Thank you for the quick fix! |
jperals
added a commit
to jperals/ace
that referenced
this pull request
Mar 6, 2024
This reverts commit 66789a7.
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5447
Description of changes:
Existing JSX mode was introduced in 2012 for a project which seems inactive now (see PR #794). This PR:
{jsx: true}option to make it work for React JSX, which is pretty much what is associated with the word JSX nowadays. Also disables jshint for JSX mode since it does not work well with JSX.JSXmode default for*.jsxfiles by removing this extension from being associated with JS mode.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.