Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signal gutterkeydown in keyboard accessibility mode #5202

Merged
merged 17 commits into from
Jun 19, 2023

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Jun 12, 2023

Issue #5200

Description of changes: For some applications, users want to react to keys being pressed in the gutter keyboard mode.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 96.29% and project coverage change: +0.01 🎉

Comparison is base (84e653e) 87.17% compared to head (61ce4a8) 87.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5202      +/-   ##
==========================================
+ Coverage   87.17%   87.19%   +0.01%     
==========================================
  Files         565      565              
  Lines       45075    45121      +46     
  Branches     6910     6910              
==========================================
+ Hits        39295    39342      +47     
+ Misses       5780     5779       -1     
Flag Coverage Δ
unittests 87.19% <96.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mouse/default_gutter_handler.js 72.78% <80.00%> (+1.06%) ⬆️
src/keyboard/gutter_handler.js 89.89% <95.23%> (+0.61%) ⬆️
src/keyboard/gutter_handler_test.js 99.46% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akoreman akoreman marked this pull request as ready for review June 15, 2023 20:43
@InspiredGuy InspiredGuy merged commit 538b18c into ajaxorg:master Jun 19, 2023
@akoreman akoreman deleted the gutter_keyboard_event branch June 19, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to intercept keyboard events on gutter (with enableKeyboardAccessibility enabled)
2 participants