chore: remove usage of deprecated setCapture api #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
force-pushed
the
remove-set-capture
branch
3 times, most recently
from
ac76b58 to
a8f65b1
Compare
Codecov ReportBase: 86.14% // Head: 86.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5058 +/- ##
==========================================
+ Coverage 86.14% 86.20% +0.06%
==========================================
Files 548 548
Lines 41692 41700 +8
Branches 6563 6564 +1
==========================================
+ Hits 35917 35949 +32
+ Misses 5775 5751 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nightwing
force-pushed
the
remove-set-capture
branch
from
a8f65b1 to
7968105
Compare
nightwing
force-pushed
the
remove-set-capture
branch
from
7968105 to
bab115a
Compare
InspiredGuy
approved these changes
Feb 15, 2023
| @@ -1,4 +1,4 @@ | |||
| module.exports = `/* | |||
| /* | |||
There was a problem hiding this comment.
is this comment needed? maybe we could remove it as well?
There was a problem hiding this comment.
this is useful for generating the css code below it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5047
The intention of this code was to keep cursor as text cursor while selecting, when mouse was over a fold widget or outside of the editor. But this worked only on firefox.
If we want to keep this behavior, we can add
if it doesn't cause problems on mobile.