Add support for resolvers with a custom protocol handler #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolang
commented
Mar 11, 2024
| } | ||
|
|
||
| override def getVersions( | ||
| organization: String, | ||
| artifactId: String, | ||
| attrs: Map[String, String] | ||
| ): Future[Seq[ArtifactVersion]] = { | ||
| val location = | ||
| protocol + Paths.get(base, organization.split('.').mkString("/"), artifactId, "maven-metadata.xml").toString | ||
| val location = new URI(s"$protocol$base/${organization.split('.').mkString("/")}/$artifactId/maven-metadata.xml") |
There was a problem hiding this comment.
Changed this because it was failing on windows due to \ in the file path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we have some resolvers using a custom protocol handler that can be registered globally for example like in this plugin https://github.com/abdolence/sbt-gcs-resolver , but
sbt-dependency-updateswasn't able to pick up updates for those.After a closer look it seemed to work with http/https only, so I tried to make it work with custom handler and came up with this update.
Have been using it locally for some time now and it seems to work well.