Append should keyword to test description #2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of the Change Adding the should keyword to an example unit test. Why should this be in core? Docs are part of the core package. Benefits Maintain consistency of documentation. Possible Drawbacks No drawbacks. Applicable issues Is this a breaking change (major release)? No Is it an enhancement (minor release)? No Is it a bug fix, or does it not impact production code (patch release)? Does not impact production code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding the should keyword to an example unit test.
Why should this be in core?
Docs are part of the core package.
Benefits
Maintain consistency of documentation.
Possible Drawbacks
No drawbacks.
Applicable issues
Is this a breaking change (major release)? No
Is it an enhancement (minor release)? No
Is it a bug fix, or does it not impact production code (patch release)? Does not impact production code.