refactor(schemautil): global default timeout minutes #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentiel
added
go
Serpentiel
force-pushed
the
aleks-refactor-global-default-timeout-minutes
branch
from
0716265 to
2827350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
makes it possible to change the default timeout of the provider's resources on compile time via
-ldflags "-X github.com/aiven/terraform-provider-aiven/internal/schemautil.DefaultTimeoutMinutes=30"resolves #1054
Why this way
to allow to change timeouts values outside of Terraform protocol during compile time