Skip to content

Commit

Permalink
Remove should_lipo argument from the Starlark interface apple_common.…
Browse files Browse the repository at this point in the history
…link_multi_arch_binary.

This feature is already a no-op, and rules_apple no longer references this argument.

PiperOrigin-RevId: 433056780
  • Loading branch information
Googler authored and copybara-github committed Mar 7, 2022
1 parent 8d92330 commit 3073f1b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ public StructImpl linkMultiArchBinary(
Sequence<?> extraLinkopts,
Sequence<?> extraLinkInputs,
StarlarkInt stamp,
Boolean shouldLipo,
StarlarkThread thread)
throws EvalException, InterruptedException {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -404,15 +404,6 @@ AppleExecutableBinaryApi newExecutableBinaryProvider(
+ "If -1 (the default), then the behavior is determined by the --[no]stamp "
+ "flag. This should be set to 0 when generating the executable output for "
+ "test rules."),
// TODO(b/63092114): Remove should_lipo when the Apple BUILD rules no longer use it.
@Param(
name = "should_lipo",
named = true,
positional = false,
defaultValue = "False",
doc =
"No-op. Kept here for backwards compatibility. This field will be removed in a "
+ "future release.")
},
useStarlarkThread = true)
// TODO(b/70937317): Iterate on, improve, and solidify this API.
Expand All @@ -422,7 +413,6 @@ StructApi linkMultiArchBinary(
Sequence<?> extraLinkopts, // <String> expected.
Sequence<?> extraLinkInputs, // <? extends FileApi> expected.
StarlarkInt stamp,
Boolean shouldLipo,
StarlarkThread thread)
throws EvalException, InterruptedException;

Expand Down

0 comments on commit 3073f1b

Please sign in to comment.