Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to PR #690 to check chrome_pref before hacking #699

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

kensoh
Copy link
Member

@kensoh kensoh commented Jan 26, 2020

No description provided.

@kensoh
Copy link
Member Author

kensoh commented Jan 26, 2020

@siowyisheng for your review and testing. After reviewing I found its better to add if exist to check that the file exists before trying to hack. Otherwise, maybe for some systems, the code will throw error twice due to the file not found in that standard location.

This change would let the hack work if the file is found, which should be the case for most users. But for users which do not have that file, avoid hacking and throw error messages.

@kensoh
Copy link
Member Author

kensoh commented Jan 30, 2020

@siowyisheng added another fine-tuning. On systems without write access to the files (lack of privilege or maybe other Chrome processes still running) will show an Access denied error. This commit mutes this error message from TagUI output as it's plain misleading to users what to do about it.

@siowyisheng
Copy link
Contributor

tested, works. merging.

@siowyisheng siowyisheng merged commit 47b2def into develop Feb 3, 2020
@siowyisheng siowyisheng deleted the windows_chrome_exit_cleanly_2 branch February 3, 2020 07:47
siowyisheng pushed a commit that referenced this pull request Mar 10, 2020
* check chrome_pref before hacking

* pipe to nul for access denied error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants