Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer to distribute Windows TagUI - use .NET + WiX Installer - done #955

Closed
kensoh opened this issue Mar 3, 2021 · 8 comments
Closed
Assignees
Labels

Comments

@kensoh
Copy link
Member

kensoh commented Mar 3, 2021

@kensoh kensoh added the feature label Mar 3, 2021
@kensoh kensoh changed the title Review using Installer for Windows TagUI - for eg Inno Setup Review using Installer to distribute Windows TagUI - for eg Inno Setup Mar 3, 2021
@kensoh kensoh changed the title Review using Installer to distribute Windows TagUI - for eg Inno Setup Review using Installer instead of zip to distribute Windows TagUI - for eg Inno Setup Mar 3, 2021
@kensoh
Copy link
Member Author

kensoh commented May 28, 2021

To compare this with using batch script to do installation.

With batch script can automate and install at scale for enterprise more easily than using Installer. For eg above can't do installation automatically (from the creator this is by design to avoid abuse)

@kensoh
Copy link
Member Author

kensoh commented May 28, 2021

some thoughts from a whatsapp chat with user

[12:44 PM, 5/28/2021] Ken Soh: For Windows, the steps to install TagUI are

1. Download TagUI v6.14 for Windows
2. Unzip the contents to C:\
3. Install OpenJDK for Windows
4. Install Chrome web browser
5. Add c:\tagui\src to start of path
6. Open Command Prompt
7. Copy, paste and run this command:
tagui c:\tagui\flows\samples\1_google.tag

[12:45 PM, 5/28/2021] Ken Soh: installer can take care of 2 (no need unzip manually) and 5 (no need add tagui command to path), and probably start installation for step 3
[12:47 PM, 5/28/2021] Ken Soh: typo should be - https://github.com/kelaberetiv/TagUI/issues/955
[12:48 PM, 5/28/2021] Ken Soh: i'm actually a bit mixed on having installer
[12:48 PM, 5/28/2021] Ken Soh: for steps 2,3,5
[12:49 PM, 5/28/2021] Ken Soh: if those steps are an hassle or difficult for user to do,
[12:49 PM, 5/28/2021] Ken Soh: then the user probably shouldn't be using TagUI
[12:49 PM, 5/28/2021] Ken Soh: because RPA work would take more tech-savviness than the steps 2,3,5 to do
[12:49 PM, 5/28/2021] Ken Soh: if it is some tech-savvy colleague that is helping to do and install
[12:50 PM, 5/28/2021] Ken Soh: then installer is more troublesome than writing own installation script that works for the company
[12:50 PM, 5/28/2021] Ken Soh: so, am feeling mix, whether such a feature is actually meaningful to add

@kensoh
Copy link
Member Author

kensoh commented May 30, 2021

Adding on another idea is a single string to copy and paste from Windows Run. And using PowerShell to download an installation script and run. This is most seamless, don't even need user to download anything. But for sites without internet access this won't work.

@kensoh
Copy link
Member Author

kensoh commented May 31, 2021

Also explore on silent automated installations of OpenJDK (downside is mess up with user's env using other versions), and the MSVC dll

@kensoh kensoh changed the title Review using Installer instead of zip to distribute Windows TagUI - for eg Inno Setup Review using Installer instead of zip to distribute Windows TagUI - use .NET Installer Jun 9, 2021
@kensoh
Copy link
Member Author

kensoh commented Jun 9, 2021

Hi @ruthtxh, assigning this item to you and I've also created this item on Basecamp to you.

@kensoh kensoh changed the title Review using Installer instead of zip to distribute Windows TagUI - use .NET Installer Review using Installer instead of zip to distribute Windows TagUI - use .NET + WiX Installer - done Jun 21, 2021
@kensoh
Copy link
Member Author

kensoh commented Jun 21, 2021

Implemented and available from https://tagui.readthedocs.io/en/latest/setup.html#windows

@kensoh kensoh closed this as completed Jun 21, 2021
@kensoh kensoh reopened this Jun 21, 2021
@kensoh
Copy link
Member Author

kensoh commented Jun 21, 2021

Reopening, issue with installer

@kensoh kensoh changed the title Review using Installer instead of zip to distribute Windows TagUI - use .NET + WiX Installer - done Installer instead of zip to distribute Windows TagUI - use .NET + WiX Installer - reported issue Jun 21, 2021
@kensoh kensoh changed the title Installer instead of zip to distribute Windows TagUI - use .NET + WiX Installer - reported issue Installer to distribute Windows TagUI - use .NET + WiX Installer - reported issue Jun 21, 2021
kensoh added a commit that referenced this issue Jun 21, 2021
@kensoh kensoh changed the title Installer to distribute Windows TagUI - use .NET + WiX Installer - reported issue Installer to distribute Windows TagUI - use .NET + WiX Installer - found issue Jun 21, 2021
kensoh added a commit that referenced this issue Jun 22, 2021
kensoh added a commit that referenced this issue Jun 22, 2021
@kensoh kensoh changed the title Installer to distribute Windows TagUI - use .NET + WiX Installer - found issue Installer to distribute Windows TagUI - use .NET + WiX Installer - added Jun 22, 2021
@kensoh kensoh changed the title Installer to distribute Windows TagUI - use .NET + WiX Installer - added Installer to distribute Windows TagUI - use .NET + WiX Installer - done Jun 22, 2021
@kensoh
Copy link
Member Author

kensoh commented Jun 22, 2021

Closing this issue too, @ruthtxh, fix is verified working!

@kensoh kensoh closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants