Rails 5.2 Fixing has one callbacks #3
Conversation
| case options[:dependent] | ||
| when :destroy | ||
| target.destroy | ||
| if target.respond_to?(:soft_destroyed?) |
There was a problem hiding this comment.
does permanent_records define soft_destroyed?
There was a problem hiding this comment.
No, I believe it is our concern that defines this method. But as permanent_records is basically unmaintained I thought it best to cover more possibilities in case our implementation becomes the actual way we do this.
There was a problem hiding this comment.
it is good to cover it in our case, but in the context of this gem, it is not provided, so thanks for removing it
| when :destroy | ||
| target.destroyed_by_association = reflection | ||
| target.destroy | ||
| if target.respond_to?(:soft_destroyed?) |
| target.destroy | ||
| if target.respond_to?(:soft_destroyed?) | ||
| raise ActiveRecord::Rollback unless target.soft_destroyed? | ||
| elsif target.respond_to?(:destroyed?) |
There was a problem hiding this comment.
also, seems like we only need to target deleted? since permanent_records handle the deleted as
def deleted?
if is_permanent?
!!deleted_at # rubocop:disable Style/DoubleNegation
else
destroyed?
end
endThere was a problem hiding this comment.
the deleted? method gets added to all AR models right?
|
@danieltheodosius I've updated to remove the extraneous method checks |
No description provided.