Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: WIP SQS integration. #918

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

belinux
Copy link

@belinux belinux commented Nov 9, 2023

Description

SQS integration for sub/pub message/s.

Fixes #794

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • New feature (a non-breaking change that adds functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the broker support Propose a new broker support label Nov 21, 2023
@Lancetnik Lancetnik self-assigned this Dec 1, 2023
@Lancetnik
Copy link
Member

I have to polish stable Redis release. Then, we can start to work on this on.

@Lancetnik
Copy link
Member

Hello there! Sorry for waiting so long: I had to refactore project structure to unblock future featrues. Now we are ready to add a new broker support: are you still interested to help me with it?
Can you please update the branch to actual FastStream structure?

@ccastleberry
Copy link

Hey, I just wanted to check in on this. I have a use case I need the SQS broker for and potentially some time to contribute to its completion, but I don't want to duplicate work if anyone else is currently working on it.

@Lancetnik
Copy link
Member

@ccastleberry thank you for the suggestion, but I freeze all new brokers support until inner structure stabilize. Can we wait for 0.6.0 release (I am planning to make all breaking changes in it) and come back to SQS then?

@ccastleberry
Copy link

Sure, any estimate on when you expect that to get 0.6.0 released? I don't want to use propan since it's deprecated in favor of fast stream and I'd rather spend my time contributing than building an in house solution for sqs.

@Lancetnik
Copy link
Member

Sure, any estimate on when you expect that to get 0.6.0 released? I don't want to use propan since it's deprecated in favor of fast stream and I'd rather spend my time contributing than building an in house solution for sqs.

October, I hope. I am planning to focus on 0.6.0 now and release it as soon as possible. Then we can add a new broker support in a few days.

@ccastleberry
Copy link

Oh wow. Thanks for the info. I look forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broker support Propose a new broker support
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

SQS support
3 participants