-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add asyncapi_url
broker arg
#903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kumaranvpl can you please use the Issue description for detail release notes? |
davorrunje
approved these changes
Nov 1, 2023
@kumaranvpl can you please use the PR description to update release note by some details? Peoples should know about changes explicitly, not only by PRs list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now user can overrides the original broker url in AsyncAPI schema only with
asyncapi_url
broker argumentIt can be extremelly hepful to hide connection credentials in a public documentation
Also, in the RMQ case, keyword arguments are overrides the original url, so
Also, RMQ AsyncAPI protocol now defines automatically from "amqp"/"amqps"
Also, RMQ supports
BaseSecurity
andSASLPlaintext
as asecurity
option for nowAlso, mv
faststream.broker.security
tofaststream.security
with deprecation noticeFixes #895, Close #578
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-anaylysis.sh