Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path operations #823

Merged
merged 16 commits into from
Oct 15, 2023
Merged

Path operations #823

merged 16 commits into from
Oct 15, 2023

Conversation

Lancetnik
Copy link
Member

@Lancetnik Lancetnik commented Oct 9, 2023

Description

Little Context refactor (support access to dict fields) -> add Header and Path (RMQ, Nats) objects

Shorter message imports

faststream.nats.annotations.NatsMessage -> faststream.nats.NatsMessage

Fix FastAPI plugin .pyi arguments

Fix some docs styles, fill publisher docs pages, add Header and Path docs sections

close #682
close #764

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the enhancement New feature or request label Oct 9, 2023
@Lancetnik Lancetnik self-assigned this Oct 9, 2023
@Lancetnik Lancetnik marked this pull request as draft October 9, 2023 20:08
@Lancetnik Lancetnik marked this pull request as ready for review October 10, 2023 15:09
@Lancetnik Lancetnik marked this pull request as draft October 10, 2023 15:32
@Lancetnik Lancetnik marked this pull request as ready for review October 12, 2023 09:33
@Lancetnik
Copy link
Member Author

@kumaranvpl can you please check docs changes?

Then, PR is ready to merge, so you can request for Davor approve and we can release 0.2.4

@kumaranvpl
Copy link
Contributor

@Lancetnik Sorry. I just saw your comment. Will check it tomorrow as first thing.

@kumaranvpl
Copy link
Contributor

@Lancetnik @davorrunje Proofreading done and I have pushed my changes.

@davorrunje davorrunje added this pull request to the merge queue Oct 15, 2023
Merged via the queue into main with commit 6335518 Oct 15, 2023
23 checks passed
@davorrunje davorrunje deleted the path-operations branch October 15, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature: support path-based arguments Fill publisher section pages in Getting started
3 participants