Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Kafka acknowledgement #793

Closed
wants to merge 20 commits into from
Closed

Adds Kafka acknowledgement #793

wants to merge 20 commits into from

Conversation

Lancetnik
Copy link
Member

Description

Minor update draft to accumulate new features

  1. adds Kafka acknowledgement

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the enhancement New feature or request label Oct 3, 2023
@Lancetnik Lancetnik marked this pull request as draft October 3, 2023 16:06
@davorrunje davorrunje changed the title 0.2.1 Adds Kafka acknowledgement Oct 4, 2023
@davorrunje davorrunje closed this Oct 4, 2023
@davorrunje davorrunje deleted the 0.2.1 branch October 4, 2023 12:20
@davorrunje
Copy link
Collaborator

I renamed the branch and it got automatically closed, please create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants