776 docs publish docs for minor version not for every patch #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaranvpl
reviewed
Sep 29, 2023
| @@ -22,7 +22,7 @@ jobs: | |||
| path: .cache | |||
| - run: pip install -e ".[dev]" | |||
| - run: ./scripts/build-docs.sh | |||
| - run: echo "VERSION=$(python3 -c 'from importlib.metadata import version; print(version("""faststream"""))')" >> $GITHUB_ENV | |||
| - run: echo "VERSION=$(python3 -c 'from importlib.metadata import version; print(".".join(version("faststream").split(".")[:2]))')" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
This will not work. VERSION itself is inside double quotes and then python lines are inside single quotes.
You need to use triple quotes for strings.
kumaranvpl
requested changes
Sep 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kumaranvpl
deleted the
776-docs-publish-docs-for-minor-version-not-for-every-patch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish documentation under minor version instead of patch (e.g. 0.1 instead of 0.1.x).
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-anaylysis.sh