Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bufixes 745 #749

Merged
merged 15 commits into from
Sep 26, 2023
Merged

Bufixes 745 #749

merged 15 commits into from
Sep 26, 2023

Conversation

Lancetnik
Copy link
Member

Description

Close #745, also add group_id as a part of consumer key, so

@broker.subscriber("test-topic", group_id="1")
...

@broker.subscriber("test-topic", group_id="2")
...

Are different subscribers now

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the bug Something isn't working label Sep 26, 2023
@davorrunje davorrunje added this pull request to the merge queue Sep 26, 2023
@Lancetnik Lancetnik removed this pull request from the merge queue due to a manual request Sep 26, 2023
@Lancetnik
Copy link
Member Author

Wait a bit

@davorrunje davorrunje added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 465ae82 Sep 26, 2023
18 checks passed
@davorrunje davorrunje deleted the bufixes-745 branch September 26, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: FastAPI KafkaRouter broken batch consuming
2 participants