Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to pass nkeys_seed_str as argument for NATS broker. #1908

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Drakorgaur
Copy link
Contributor

@Drakorgaur Drakorgaur commented Nov 8, 2024

This would simplify the usage of applications without a need to read files.

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

This would simplify the usage of applications without a need to read files.
Lancetnik
Lancetnik previously approved these changes Nov 8, 2024
@Lancetnik
Copy link
Member

Thank you a lot for the PR! Can it wait a few days? I didn't want to release a new version so far

@Lancetnik Lancetnik added this pull request to the merge queue Nov 8, 2024
Merged via the queue into airtai:main with commit 0d4c237 Nov 8, 2024
32 checks passed
@Drakorgaur
Copy link
Contributor Author

Thank you a lot for the PR! Can it wait a few days? I didn't want to release a new version so far

Of course!
Thanks for fast check, review and feedback :)

Drakorgaur added a commit to Drakorgaur/faststream that referenced this pull request Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants