Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct minimum FastAPI version for lifespan handling #1853

Merged

Conversation

tim-hutchinson
Copy link
Contributor

@tim-hutchinson tim-hutchinson commented Oct 16, 2024

Description

Based on the git blame and #1736, I believe the minimum version of FastAPI for handling lifespan functions correctly is 112.2, not 102.2. Just ran into this trying to work out why our broker was never getting connected on an older (103) FastAPI install.

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik
Copy link
Member

Thank you for the notice and PR a lot!

@Lancetnik Lancetnik added the documentation Improvements or additions to documentation label Oct 16, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Oct 16, 2024
Merged via the queue into airtai:main with commit 8524b7f Oct 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants