Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainers supporting all the brokers #1839

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

kumaranvpl
Copy link
Contributor

Description

In this PR, I have updated devcontainers in order to launch all the brokers as part of devcontainers itself. Now development can be done from devcontainer itself. I have followed fastagency's naming scheme for devcontainer's container names, so theoretically codespaces should work without any extra modifications.

Only problem is I had to include both python 3.12 and python 3.10 because some pre-commit hooks requires python 3.10. I have tried to switch to python 3.12 for all the pre-commit hooks but it throws too many mypy issues. I will create a separate issue to fix the mypy issues.

@davorrunje and @Lancetnik Please review this PR and let me know what you think about the changes.

Fixes #1804

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added this pull request to the merge queue Oct 8, 2024
@Lancetnik Lancetnik removed this pull request from the merge queue due to a manual request Oct 8, 2024
@Lancetnik
Copy link
Member

Close #1351 as well

@Lancetnik
Copy link
Member

LGTM, you are able to merge

@kumaranvpl kumaranvpl linked an issue Oct 8, 2024 that may be closed by this pull request
@kumaranvpl
Copy link
Contributor Author

LGTM, you are able to merge

@Lancetnik Have you tried it? If not, please checkout to my branch, rebuild container(without cache). Once rebuilding is done, please open a new terminal and just play with it by running a random test or something else.

@kumaranvpl kumaranvpl added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit a817094 Oct 8, 2024
27 checks passed
@kumaranvpl kumaranvpl deleted the polish-devcontainers branch October 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create devcontainer for confluence Add dev containers (for different brokers and for all brokers)
2 participants