Add devcontainers supporting all the brokers #1839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have updated devcontainers in order to launch all the brokers as part of devcontainers itself. Now development can be done from devcontainer itself. I have followed
fastagency
's naming scheme for devcontainer's container names, so theoreticallycodespaces
should work without any extra modifications.Only problem is I had to include both python 3.12 and python 3.10 because some pre-commit hooks requires python 3.10. I have tried to switch to python 3.12 for all the pre-commit hooks but it throws too many mypy issues. I will create a separate issue to fix the mypy issues.
@davorrunje and @Lancetnik Please review this PR and let me know what you think about the changes.
Fixes #1804
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh