-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection Page #30
Collection Page #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…redux Co-authored-by: Kris Goddard <[email protected]>
Short video showing the collection page: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Things are working nicely. I added some commits to make it more solid:
-
Your
fetchNFTMetadata
was not setup properly. You only have to make it return a promise and then get the responses in a reducer with the pending, fulfilled, and rejected. So I removed all the collection reducers because they are simply not necessary. -
You had an
await fetchCallback()
inside theuseInfiniteScroll
. You should keep all async logic inside the store. So I added anisLoading
to the collection store. -
I removed
configureCollectionSubscriber
. I understand it's confusing that there's also aconfigureBalancesSubscriber
andconfigureMetadataSubscriber
. But those subscribers are there because those stores can not be called from a specificwidget
. The collection store is connected to the CollectionWidget, so actions can be called from there. -
You used a lot of
grid
in your css. It's only necessary when you're using a grid, like the nfts grid. So I left it there only. -
You had a
onClick
prop on NftCard and usednavigate
for navigation. You should simply useNavLink
without any listeners. -
You had classNames like
collection-widget__content__subtitle
, while technically correct it's better to just usecollection-widget__subtitle
.
Things that still need work I have made tickets for:
Infinite scroll and loader needs some work still:
#45
IERC1155 support:
#46
Price of token:
#47
Error handling:
#48
Add support for irregular token id numbers
#49
Implementing #22 #11