Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asv compare variant #789

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lothiraldan
Copy link
Contributor

This is a Work In Progress command to be able to compare two variants on the same commit. We are starting to use it right now to validate the UX and use-cases.

I've tried to refactor the compare command to reduce the amount of duplicated code to a maximum.

Before putting more effort on the code, having your view if this feature is useful and what form should it takes would be invaluable. I'm hesitating between a new compare_variant command or a compare flag?

@pv
Copy link
Collaborator

pv commented May 25, 2019

I'd prefer retaining it all in asv compare command, e.g. syntax asv compare envname1:xxx envname2:yyy. The feature itself certainly should be added (closes #370).

EDIT: reading this again, it seems to be about parametrized benchmarks --- in which case --bench foo(param1, param2, ...) or similar would be the syntax, following other commands that support parametrized benchmarks. However, comparison across environments would also be useful.

@pv pv added the needs-work The PR cannot be merged as is, further work required (explained in comments) label May 25, 2019
@HaoZeke HaoZeke mentioned this pull request Apr 23, 2023
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work The PR cannot be merged as is, further work required (explained in comments)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants