Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give up offline Conda in tests, seems to get too complicated #783

Merged
merged 1 commit into from
Jan 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ install:
- $TRAVIS_PYTHON setup.py build_ext -i

script:
- $TRAVIS_PYTHON -m pytest -l $COVERAGE -vv --webdriver=FirefoxHeadless -n 3 --offline test
- $TRAVIS_PYTHON -m pytest -l $COVERAGE -vv --webdriver=FirefoxHeadless -n 3 test

after_script:
- if [[ "$COVERAGE" != '' ]]; then
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ install:
build: false

test_script:
- "python -m pytest -l --basetemp=%APPVEYOR_BUILD_FOLDER%\\tmp -vv -n 3 --offline --webdriver=FirefoxHeadless test"
- "python -m pytest -l --basetemp=%APPVEYOR_BUILD_FOLDER%\\tmp -vv -n 3 --webdriver=FirefoxHeadless test"

after_build:
# Clear up pip cache
Expand Down
7 changes: 0 additions & 7 deletions test/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ def pytest_addoption(parser):
"with a return statement with selenium.webdriver object, for "
"example 'return Chrome()'"))

parser.addoption("--offline", action="store_true", default=False,
help=("Do not download items from internet. Use if you have predownloaded "
"packages with Conda. (Virtualenv tests are always offline.)"))


def pytest_sessionstart(session):
os.environ['PIP_NO_INDEX'] = '1'

if session.config.getoption('offline'):
os.environ['CONDA_OFFLINE'] = 'True'