Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update CI configurations and handle sanity checks #1440

Merged
merged 16 commits into from
Nov 24, 2024

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Nov 18, 2024

Closes #1437. Closes #1384. Partially addresses #1438 by at the very least explaining that only 1.x is supported.

Draft until:

  • [wheel build] works with upload-artifact@v4.

Since otherwise... the CI:

```bash
python3.7/site-packages/pip/_vendor/rich/console.py", line 41, in <module>
                 from pip._vendor.typing_extensions import (
               File "/tmp/pytest-of-runner/pytest-0/test_custom_commands0/env/a80b4bcff004e7d21aafa78a5932418b/lib/python3.7/site-packages/pip/_vendor/typing_extensions.py", line 1039
                 def TypedDict(typename, fields=_marker, /, *, total=True, closed=False, **kwargs):

```

https://github.com/airspeed-velocity/asv/actions/runs/11886497250/job/33117760424?pr=1440
@HaoZeke HaoZeke marked this pull request as draft November 18, 2024 06:09
@HaoZeke HaoZeke changed the title MAINT: Update CI configurations MAINT: Update CI configurations and handle sanity checks Nov 23, 2024
@HaoZeke HaoZeke marked this pull request as ready for review November 23, 2024 17:58
@HaoZeke HaoZeke requested a review from mattip November 23, 2024 17:58
@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 23, 2024

Sorry, drafting this again for the [wheel build]

@HaoZeke HaoZeke marked this pull request as draft November 23, 2024 17:59
R is a very heavy dependency for a very simple test..
@HaoZeke HaoZeke marked this pull request as ready for review November 23, 2024 18:37
@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 23, 2024

Should be good to go.

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 24, 2024

In it goes, thanks @mattip

@HaoZeke HaoZeke merged commit e36e1c7 into airspeed-velocity:main Nov 24, 2024
15 checks passed
@HaoZeke HaoZeke deleted the updateBPlat branch November 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants