Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Try windows on github again #1332

Merged
merged 14 commits into from
Sep 10, 2023
Merged

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Aug 24, 2023

Continuing from #1119.

@HaoZeke HaoZeke force-pushed the addWinCI branch 9 times, most recently from e6428c7 to 9478871 Compare August 24, 2023 19:21
@HaoZeke
Copy link
Member Author

HaoZeke commented Aug 24, 2023

3.7 on windows GHA works with virtualenv. The AppVeyor configuration uses conda, but also runs only 3.7.

@HaoZeke
Copy link
Member Author

HaoZeke commented Aug 25, 2023

@mattip I think this is good to go, feature compatible with the existing appveyor configuration and runs faster.

@mattip
Copy link
Contributor

mattip commented Aug 27, 2023

CI on windows is failing, both on appveyor and on github actions

@HaoZeke HaoZeke force-pushed the addWinCI branch 3 times, most recently from 2b1fc0b to 77b6caf Compare September 10, 2023 19:13
@HaoZeke HaoZeke force-pushed the addWinCI branch 3 times, most recently from 021643c to 1a80863 Compare September 10, 2023 19:35
@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 10, 2023

@mattip this should be ready to go, appveyor fails because the configuration has been removed.

@mattip mattip merged commit 31c0f39 into airspeed-velocity:master Sep 10, 2023
@mattip
Copy link
Contributor

mattip commented Sep 10, 2023

Cool, thanks. I will remove the appveyor integration from the repo.

@HaoZeke HaoZeke deleted the addWinCI branch September 10, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants