MAINT: Datetime deprecations #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoZeke
force-pushed
the
datetimeDeprecations
branch
from
0eeb190 to
0427260
Compare
|
Is there a CI run with 3.12rc1? |
Since Python 3.3, these have been the same. https://docs.python.org/3.3/whatsnew/3.3.html#pep-3151-reworking-the-os-and-io-exception-hierarchy
HaoZeke
force-pushed
the
datetimeDeprecations
branch
from
cbbbb2e to
89a53d4
Compare
HaoZeke
force-pushed
the
datetimeDeprecations
branch
from
3110183 to
91acbd3
Compare
We do now :) I think this is good to go. |
mattip
reviewed
Sep 10, 2023
| @@ -198,7 +198,7 @@ def iter_unique(iter): | |||
| try: | |||
| with open(result_file, 'r') as fp: | |||
| benchmarks = json.load(fp) | |||
| except (IOError, ValueError): | |||
| except (OSError, ValueError): | |||
There was a problem hiding this comment.
I think these should be split into two at some point. The errors are very different, one is that the expected file cannot be found, the other is something else (what?) that fails during discovery.
|
I think it is fine to drop pypy3.8 testing. The version is not supported upstream, and the test is very slow. Other than one small nit, not really connected to this PR, it all looks good, thanks. I will merge as-is, the two comments can be dealt with elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1322.