Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix poetry / pdm usage #1282

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Apr 28, 2023

Closes #1281. Also implements handing poetry and pdm with a much cleaner approach.

@HaoZeke HaoZeke requested a review from mattip April 28, 2023 23:31
@DavidRConnell
Copy link
Contributor

This is working for my poetry project. Thank you. Having pip handle the different backends like this is a nicer solution. Surprised pip doesn't automatically install the backend.

Should the requirement for poetry packages be poetry-core instead of poetry (line 507)? installing poetry-core is working for me as well and the poetry-core README indicates it is meant to replace the full poetry package for this purpose.

@HaoZeke
Copy link
Member Author

HaoZeke commented Apr 29, 2023

This is working for my poetry project. Thank you. Having pip handle the different backends like this is a nicer solution. Surprised pip doesn't automatically install the backend.

Excellent, thanks for confirming and yeah it would make much more sense for pip to respect build-backend...

Should the requirement for poetry packages be poetry-core instead of poetry (line 507)? installing poetry-core is working for me as well and the poetry-core README indicates it is meant to replace the full poetry package for this purpose.

It wasn't immediately clear to me that poetry.core is enough to handle all the additional fields poetry uses, e.g. I thought it would be ok for a pyproject.toml which just builds with poetry but not if there was heavy use of the keys under [tool.poetry]... I think it should be ok though, am updating, thanks for the heads up!

@mattip mattip merged commit 5da0dd3 into airspeed-velocity:master Apr 30, 2023
@mattip
Copy link
Contributor

mattip commented Apr 30, 2023

Thanks @HaoZeke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Poetry doesn't have --output
3 participants