-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Fixup and remove bundled dependencies #1234
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e63ed98
MAINT: Fixup and reduce external dependencies
HaoZeke 2739cf7
MAINT: Test for PYPY
HaoZeke e243e9d
MAINT: Use correct names
HaoZeke b63a970
MAINT: Add deps
HaoZeke 04eebeb
BLD: Ensure pympler is present
HaoZeke c1245cc
MAINT: Rework call again for pympler
HaoZeke e2d7bde
MAINT: Incredibly hacky grab for ASV
HaoZeke 7573d3b
MAINT: Silence linter, add dep
HaoZeke 3863357
BLD: Update AppVeyor
HaoZeke 612c01b
MAINT: Cleanup function to cache known paths
HaoZeke 24f66da
TMP,TST: Only check the buggy test
HaoZeke 05ff5dc
MAINT: Try a Windows fix
HaoZeke 78a719d
MAINT: Rework to check conda environments too
HaoZeke 905c326
MAINT: Yet another fallback
HaoZeke e8919d7
MAINT: No more fallbacks, use the right path
HaoZeke 4ea96eb
TST: Test all the things on CI again
HaoZeke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need all this? If the import fails, can't we just fail the run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that the import fails where it shouldn't, e.g. on the CI. This seems to be because of the process isolation (each ASV run is in a different subprocess, which doesn't include
asv
and on CI cannot usepip
either). Perhaps, now that I'm thinking about it, it would be cleaner to instead importasv
itself, which would automatically bring inpympler
and is discussed in #908There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I went with that approach then the Import Mechanism would instead load ASV rather than
asizeof
, but I'm not sure how to simplify this further without breaking the subprocess approach.