Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change function format to f-string asv/commands/rm.py #1186

Merged
merged 1 commit into from
Mar 20, 2022
Merged

change function format to f-string asv/commands/rm.py #1186

merged 1 commit into from
Mar 20, 2022

Conversation

Daniet
Copy link
Contributor

@Daniet Daniet commented Mar 20, 2022

xref #1077 #1181
Change f-strings instead .format() on asv/commands/rm.py

@dorothykiz1
Copy link
Contributor

Thanks @Daniet for working on this.lgtm @datapythonista this PR is ready

LucyJimenez
LucyJimenez approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@LucyJimenez LucyJimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @Daniet
LGTM 🚀

@datapythonista datapythonista merged commit cd9aee1 into airspeed-velocity:master Mar 20, 2022
@LucyJimenez LucyJimenez mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucyJimenez LucyJimenez LucyJimenez approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daniet @dorothykiz1 @datapythonista @LucyJimenez