Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .format to f string on asv/machine.py #1185

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

asnramos
Copy link
Contributor

xref #1176 #1077
Change f-strings instead .format() on asv/machine.py

Copy link
Contributor

@LucyJimenez LucyJimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @asnramos. I leave you just one comment :)

asv/machine.py Outdated Show resolved Hide resolved
asnramos and others added 2 commits March 20, 2022 20:13
Ok!

Co-authored-by: Lucy Jiménez <[email protected]>
#Check Error in the morning...
@datapythonista
Copy link
Member

@asnramos CI is red, one line is longer than the maximum we allow, 99 characters. Can you check and split it in two lines please?

asv/machine.py Outdated Show resolved Hide resolved
asv/machine.py Outdated Show resolved Hide resolved
Ok With the suggestion for make a new line of code, Thanks

Co-authored-by: Lucy Jiménez <[email protected]>
Copy link
Contributor

@LucyJimenez LucyJimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@datapythonista datapythonista merged commit 03d2bc8 into airspeed-velocity:master Mar 21, 2022
@datapythonista
Copy link
Member

Thanks @asnramos, really nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants