CLN:fix flake8 errors in test/test_publish.py #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test_publish.py
Outdated
| @@ -305,11 +305,13 @@ def test_regression_non_monotonic(dvcs_type, tmpdir): | |||
| tmpdir = str(tmpdir) | |||
| now = datetime.datetime.now() | |||
|
|
|||
| dates = [now + datetime.timedelta(days=i) for i in range(5)] + [now - datetime.timedelta(days=i) for i in range(5)] | |||
| dates = [now + datetime.timedelta(days=i) | |||
| for i in range(5)] + [now - datetime.timedelta(days=i)for i in range(5)] | |||
There was a problem hiding this comment.
missing space before for.
test/test_publish.py
Outdated
| @@ -329,16 +331,16 @@ def test_regression_threshold(generate_result_dir): | |||
| tools.run_asv_with_conf(conf, "publish") | |||
| regressions = util.load_json(join(conf.html_dir, "regressions.json")) | |||
| expected = {"regressions": [["time_func", _graph_path(repo.dvcs), {}, None, | |||
| 2.0, 1.0, [[None, 5, 1.0, 1.1], [None, 10, 1.1, 2.0]], | |||
| ]]} | |||
| 2.0, 1.0, [[None, 5, 1.0, 1.1], [None, 10, 1.1, 2.0]], ]] | |||
There was a problem hiding this comment.
Suggested change
| 2.0, 1.0, [[None, 5, 1.0, 1.1], [None, 10, 1.1, 2.0]], ]] | |
| 2.0, 1.0, [[None, 5, 1.0, 1.1], [None, 10, 1.1, 2.0]]]]} |
test/test_compare.py
Outdated
| @@ -98,7 +98,7 @@ | |||
| REFERENCE_ONLY_CHANGED = """ | |||
| before after ratio | |||
| [22b920c6] [fcf8c079] | |||
| <name1> <name2> | |||
There was a problem hiding this comment.
Revert changes to this file for now, and keep it in excluded.
There was a problem hiding this comment.
ok great,thanks @datapythonista noted
dorothykiz1
changed the title
|
@datapythonista this PR is ready for review |
|
Thanks @dorothykiz1, very nice, good to see the exclude list groomed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1042