Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata.yaml should be a complete kubernetes style yaml #530

Closed
jezogwza opened this issue Apr 21, 2021 · 5 comments
Closed

Metadata.yaml should be a complete kubernetes style yaml #530

jezogwza opened this issue Apr 21, 2021 · 5 comments
Assignees
Labels
bug Something isn't working priority/medium Default priority for items size m
Milestone

Comments

@jezogwza
Copy link
Contributor

jezogwza commented Apr 21, 2021

Need to add kind, etc to the file .

apiVersion: airshipit.org/v1alpha1
kind: AirshipMetadata
metadata:  name: airship-metadata
spec:
phase: 
docEntryPointPrefix: manifests/site/test-site 
path: manifests/site/test-site/phases
inventory: 
path: manifests/site/test-site/host-inventory

@jezogwza jezogwza added bug Something isn't working triage Needs evaluation by project members priority/medium Default priority for items and removed triage Needs evaluation by project members labels Apr 21, 2021
@jezogwza jezogwza modified the milestones: Future, v2.1 Apr 28, 2021
@jezogwza
Copy link
Contributor Author

Will follow the same model of using the API generation model discussed in the other issue about Catalog Schema.

@vetbijaya
Copy link
Contributor

I can try on this one. Can someone assign this to me?

@airshipbot
Copy link

airshipbot commented May 6, 2021

Related Change #790155

Subject: [WIP] Update metadata yaml in kubernetes style
Link: https://review.opendev.org/c/airship/airshipctl/+/790155
Status: ABANDONED
Owner: Bijaya Sharma ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
! None
Verified
-1 Zuul
Workflow
! None

Last Updated: 2021-05-21 09:39:44 CDT

@airshipbot
Copy link

airshipbot commented May 19, 2021

Related Change #792060

Subject: Update metadata.yaml to kubernetes style
Link: https://review.opendev.org/c/airship/airshipctl/+/792060
Status: NEW
Owner: Sirajudeen ([email protected])

Approvals

Code-Review
+1 Matthew Fuller
+2 Ian Howell
+1 Bijaya Sharma
Verified
+1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-05-25 15:58:59 CDT

airshipbot pushed a commit that referenced this issue Jun 9, 2021
* Define GVK for metadata.yaml
* Added supoorting type and registered the kind 'AirshipMetadata' to
  runtime scheme
* Used document object to read metadata instead of reading it as config

Relates-To: #530

Change-Id: I748cd0921ba7bb04ca6fb2999294776e6803ed3e
@sirajyasin
Copy link
Contributor

@lb4368 ,
The related PS is already merged and this issue can be marked closed.

@lb4368 lb4368 closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium Default priority for items size m
Projects
None yet
Development

No branches or pull requests

5 participants