Airshipbot appears to be reopening issues right after closing them

[eak13]

Describe the bug
Several recent issues have been closed upon code merge & then immediately reopened by the Airshipbot. Examples are #482, #485, #370 & #419. Initially thought it might be due to there being both the "Relates-To:" and "Closes:" tags in the commit message but #419 does not appear to have both tags. The other three examples do. Per comments below, does not appear to be commit label related.

Expected behavior
Closed issues stay closed upon closing patchset merging.

[raliev12]

@ak3216 I've investigated this issue a little bit, and it seems it has no relations with airshipctl code and update-github-issues job. This bug reproduces as sequence of the following events:

1. Once a commit merged into master, it triggers airshipbot to close this issue
2. post and promote jobs are starting; as part of promote job we run update-github-issues.py script, which leaves a comment to issue (The Change that closes this issue was merged) and removes some labels from it, like wip, ready-for-review and so on. Removing labels from the issue most likely is not the cause why the issue reopens again (since reopening in this case should happen immediately).
3. After some time, once post and promote completed (like 5-15 minutes), some "gerrit" activity (Issue reopened due to new activity on Gerrit) triggers airshipbot to reopen the issue.

I can't say for sure, but 90% this issue isn't related with airshipctl code and zuul jobs. Something should be checked in airshipbot configuration. I don't know who owns it and how it is configured inside, but seems the root cause is there.

[eak13]

@raliev12, thanks for looking into this. @sirajyasin, can you please see if something is going on with the airshipbot? Thanks.

[sirajyasin]

@ak3216 , I can look into this issue. Could you please assign this issue to me.

[eak13]

All yours @sirajyasin, thanks!

[airshipbot]

Related Change #786694

Subject: Disable the redundant github issue update job
Link: https://review.opendev.org/c/airship/airshipctl/+/786694
Status: MERGED
Owner: Sirajudeen ([email protected])

Approvals

Code-Review
+2 Ian Howell
+1 Bijaya Sharma
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2021-04-20 20:39:46 CDT

[airshipbot]

Related Change #787250

Subject: Delete GitHub token
Link: https://review.opendev.org/c/airship/airshipctl/+/787250
Status: NEW
Owner: Roman Gorshunov ([email protected])

Approvals

Code-Review
+1 Sirajudeen
+1 Bijaya Sharma
+1 Sean Eagan
+2 Drew Walters
Verified
+1 Zuul
Workflow
! None

Last Updated: 2021-04-26 16:59:04 CDT

[sirajyasin]

The Related PSs for this Fix are merged. Will observe the BOT behavior for few days before closing the issue.

[eak13]

Closing this out as it appears to be resolved. No longer seeing issues being reopened.