Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance baremetal sub command to expose hosts defined in the documents #359

Closed
aschiefe opened this issue Sep 30, 2020 · 14 comments
Closed
Assignees
Labels
1-Core Relates to airshipctl core components (i.e. go code) enhancement New feature or request good first issue Good for newcomers priority/medium Default priority for items ready for review Change related to the issue is ready for review size m
Milestone

Comments

@aschiefe
Copy link

The UI will need to operate on the baremetal as defined in the manifests. However the UI is blind to the manifests and needs to know which hosts are available for the baremetal actions to be run against.

In order to complete the UI integration there will need to be a way to expose the hosts to the UI / command line to show which baremetal targets can be operated on. It would be preferable that this information is produced as a structure that can be referenced by the UI and printed in a human readable format for the CLI

The UI will be unable to complete the baremetal integration without some level of host information exposed to it for display / operational purposes.

@aschiefe aschiefe added enhancement New feature or request triage Needs evaluation by project members labels Sep 30, 2020
@jezogwza jezogwza added design needed New Design or Redesign required and removed triage Needs evaluation by project members labels Oct 14, 2020
@jezogwza jezogwza added this to the v2.0 milestone Oct 14, 2020
@eak13 eak13 added the priority/medium Default priority for items label Nov 9, 2020
@airshipbot
Copy link

airshipbot commented Nov 9, 2020

Related Change #761991

Subject: Move remote client interface to separate package
Link: https://review.opendev.org/761991
Status: NEW
Owner: Kostyantyn Kalynovskyi ([email protected])

Approvals

Code-Review
! None
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-11-11 11:30:31 CST

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Nov 9, 2020
@airshipbot
Copy link

airshipbot commented Nov 10, 2020

Related Change #759329

Subject: Add baremetal inventory implementation.
Link: https://review.opendev.org/759329
Status: NEW
Owner: Kostyantyn Kalynovskyi ([email protected])

Approvals

Code-Review
! None
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-11-11 12:00:32 CST

@airshipbot
Copy link

airshipbot commented Nov 10, 2020

Related Change #762213

Subject: Add baremetal inventory implementation.
Link: https://review.opendev.org/762213
Status: NEW
Owner: Kostyantyn Kalynovskyi ([email protected])

Approvals

Code-Review
! None
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-11-10 17:45:35 CST

@airshipbot
Copy link

airshipbot commented Nov 10, 2020

Related Change #762215

Subject: Implement RunAction method of the baremetal interface
Link: https://review.opendev.org/762215
Status: NEW
Owner: Kostyantyn Kalynovskyi ([email protected])

Approvals

Code-Review
! None
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-11-10 17:45:19 CST

airshipbot pushed a commit that referenced this issue Nov 13, 2020
This will allow to add constructors that return interface
instead of struct.

Relates-To: #397
Relates-To: #362
Relates-To: #359

Change-Id: Ia750d5c9472041b34ab74a2935ef77ae955a016e
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/761991 was merged. This issue may be ready to close.

@eak13 eak13 removed the design needed New Design or Redesign required label Dec 3, 2020
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/762213 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Dec 4, 2020
The implementation is inspired by pkg/remote module, and evolves
it to be built on top of document bundles as well as makes it
more command line oriented by adding RunOperation method.

Change-Id: If95a007986eb61c977c1ddbe5a94cfbeefeac225
Relates-To: #397
Relates-To: #362
Relates-To: #359
@eak13 eak13 added the 1-Core Relates to airshipctl core components (i.e. go code) label Dec 8, 2020
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/762215 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Jan 13, 2021
Change-Id: I86b2cd7824c68ccd4fac875a5ad1d3ff9cd69072
Relates-To: #397
Relates-To: #362
Relates-To: #359
@jezogwza jezogwza added the good first issue Good for newcomers label Feb 10, 2021
@sirajyasin
Copy link
Contributor

@ak3216 @teoyaomiqui
I assume all the core logic to fetch inventory is already implemented, however the cli command 'airshipctl bare metal list' is still pending. If no one has started working on that yet, I can look into adding the new cli command. Please suggest

@teoyaomiqui
Copy link
Contributor

@sirajyasin that is partially correct. First would be to develop an underlying extension to remote interface to be printed as YAML: https://github.com/airshipit/airshipctl/blob/master/pkg/remote/ifc/ifc.go#L25-L38

this maybe a little tricky, because when client is initialized, no instructions are given to it about the BMH object here: https://github.com/airshipit/airshipctl/blob/master/pkg/remote/ifc/ifc.go#L41-L45

so i think we may need to redefine the constructor, to encompass this information.

WHen this is done, we can implement ListCommand that would do essentially do a Select() from here https://github.com/airshipit/airshipctl/blob/master/pkg/inventory/ifc/interface.go#L30 and print each host

@teoyaomiqui
Copy link
Contributor

sorry clicked close accidentally :)

@eak13 eak13 removed this from the v2.0 milestone Mar 10, 2021
@eak13 eak13 added this to the v2.1 milestone Mar 10, 2021
@teoyaomiqui teoyaomiqui self-assigned this Apr 2, 2021
@teoyaomiqui
Copy link
Contributor

@sirajyasin do u still want to work on it?

@PratikDhanave
Copy link

@eak13 please assign to me.

@PratikDhanave
Copy link

@pallavgupta
Copy link
Contributor

@eak13 since Pratik is out for some time, pls assign this issue to me. I already started working into it.

@pallavgupta pallavgupta removed their assignment Oct 19, 2021
@lb4368 lb4368 modified the milestones: Future, v2.1 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Core Relates to airshipctl core components (i.e. go code) enhancement New feature or request good first issue Good for newcomers priority/medium Default priority for items ready for review Change related to the issue is ready for review size m
Projects
None yet
Development

No branches or pull requests

10 participants