Updated terms and policy #2232
Updated terms and policy #2232
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve updates to the content of two legal documents: the Privacy Policy and Terms of Service. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2232 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 5 5
Branches 2 2
=========================================
Hits 5 5 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
website/frontend/src/pages/Legal/PrivacyPolicy.js (3)
40-44: Ensure consistent company name references throughout the documentWhile the introduction now properly establishes "AirQo Research" and its shortened form "AirQo", we should maintain this consistency throughout the document. Consider updating all subsequent mentions of AirQo to use the
<strong>tags for visual consistency.
64-65: Consider enhancing data protection clarityWhile the commitment to responsible data use is stated, consider adding specific references to applicable data protection regulations (e.g., GDPR if relevant) and more detailed information about data protection measures. This would strengthen user trust and legal compliance.
Line range hint
258-260: Consider making the last update date dynamicThe last update date is currently hardcoded. Consider making this dynamic by:
- Moving it to a configuration file
- Using an environment variable
- Implementing an automated update mechanism tied to content changes
This would ensure the date stays current with policy updates.
- <p> - <strong>This Privacy Policy was last updated on Nov 22, 2022</strong> - </p> + <p> + <strong>This Privacy Policy was last updated on {process.env.REACT_APP_PRIVACY_POLICY_LAST_UPDATE || 'Nov 22, 2022'}</strong> + </p>website/frontend/src/pages/Legal/TermsOfService.js (2)
38-65: Consider enhancing accessibility of the introduction sectionThe content structure looks good, and I appreciate the clear welcome message. However, we could improve accessibility for screen readers.
Consider these enhancements:
<> <p> - Welcome to <strong>AirQo Research</strong> ("AirQo"). By accessing or using our + Welcome to <strong aria-label="AirQo Research">AirQo Research</strong> ("AirQo"). By accessing or using our platform, you agree to adhere to and be bound by these Terms of Service. If you do not agree with these terms, please refrain from using our platform. </p> - <ol> + <ol aria-label="Key terms and conditions"> <li> Some cities already have programs for air quality monitoring, so we collaborate with
Line range hint
32-65: Consider debouncing the scroll event handlerThe scroll event handler implementation is correct, but scroll events can fire frequently and impact performance. Consider implementing debouncing to optimize performance.
Here's how you could enhance the scroll handler:
+import { debounce } from 'lodash'; + const TermsOfService = () => { const [activeSection, setActiveSection] = useState('intro'); useEffect(() => { - const handleScroll = () => { + const handleScroll = debounce(() => { if (!sections || sections.length === 0) return; const sectionElements = sections .map((section) => document.getElementById(section.id)) .filter((element) => element !== null); if (sectionElements.length === 0) return; const currentSection = sectionElements.find((element) => { const rect = element.getBoundingClientRect(); return rect.top <= 100 && rect.bottom > 100; }); if (currentSection && currentSection.id !== activeSection) { setActiveSection(currentSection.id); } - }; + }, 100); window.addEventListener('scroll', handleScroll); return () => { window.removeEventListener('scroll', handleScroll); + handleScroll.cancel(); }; }, [sections, activeSection]);Also applies to: 441-467
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
website/frontend/src/pages/Legal/PrivacyPolicy.js(2 hunks)website/frontend/src/pages/Legal/TermsOfService.js(1 hunks)
|
New Website changes available for preview here |
|
New Website changes available for preview here |
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
How should this be manually tested?
What are the relevant tickets?
Screenshots (optional)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation