Add support for LZ4 frame format #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2022
findepi
force-pushed
the
findepi/lz4frame
branch
3 times, most recently
from
9103d8e
to
82f6244
Compare
findepi
commented
Apr 12, 2022
| @@ -107,7 +107,7 @@ | |||
| <groupId>org.lz4</groupId> | |||
| <artifactId>lz4-java</artifactId> | |||
| <version>1.8.0</version> | |||
| <scope>test</scope> | |||
| <!-- TODO move to test scope once we have XxHash32 --> | |||
Comment on lines
+39
to
+48
| protected boolean isByteBufferSupported() | ||
| { | ||
| // TODO support byte buffer | ||
| return false; |
There was a problem hiding this comment.
JVM crashed when testing with direct buffers. I didn't figure out why yet.
src/test/java/io/airlift/compress/thirdparty/JPountzLz4FrameCompressor.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/lz4frame
branch
from
82f6244
to
541d611
Compare
|
( rebased after extracted PRs merged ) |
findepi
force-pushed
the
findepi/lz4frame
branch
from
541d611
to
dc1ae48
Compare
Implement LZ4 frame compression. (spec snapshot https://github.com/lz4/lz4/blob/3e99d07bc09e1b82ee6191527bb3e555052c55ac/doc/lz4_Frame_format.md , current version https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md ).
findepi
force-pushed
the
findepi/lz4frame
branch
from
dc1ae48
to
8d787d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.