Set the JVM locale fix to en-US when running tests #98

wenleix · 2016-12-24T03:18:44Z

This avoids different exception messages under different system
languages.

wenleix · 2016-12-24T03:21:04Z

This fixes prestodb/presto#6655, as I verified the tests will succeed under Polish language setting.

However, when I set the Presto root pom.xml to use 60-SNAPSHOT and run mvn clean install, I see the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on project presto-main: Compilation failure: Compilation failure:
[ERROR] /Users/wxie/Code/presto-all/presto/presto-main/src/main/java/com/facebook/presto/operator/scalar/ScalarFunctionImplementation.java:[62,17] reference to checkArgument is ambiguous
[ERROR] both method checkArgument(boolean,java.lang.String,java.lang.Object,java.lang.Object) in com.google.common.base.Preconditions and method checkArgument(boolean,java.lang.String,int,java.lang.Object) in com.google.common.base.Preconditions match
[ERROR] /Users/wxie/Code/presto-all/presto/presto-main/src/main/java/com/facebook/presto/operator/NestedLoopJoinPagesSupplier.java:[49,16] no suitable method found for transform(com.google.common.util.concurrent.SettableFuture<com.facebook.presto.operator.NestedLoopJoinPages>,com.google.common.util.concurrent.AsyncFunction<com.facebook.presto.operator.NestedLoopJoinPages,com.facebook.presto.operator.NestedLoopJoinPages>)
[ERROR] method com.google.common.util.concurrent.Futures.<I,O>transform(com.google.common.util.concurrent.ListenableFuture<I>,com.google.common.base.Function<? super I,? extends O>,java.util.concurrent.Executor) is not applicable
[ERROR] (cannot infer type-variable(s) I,O
[ERROR] (actual and formal argument lists differ in length))
[ERROR] method com.google.common.util.concurrent.Futures.<I,O>transform(com.google.common.util.concurrent.ListenableFuture<I>,com.google.common.base.Function<? super I,? extends O>) is not applicable
[ERROR] (cannot infer type-variable(s) I,O
[ERROR] (argument mismatch; com.google.common.util.concurrent.AsyncFunction<com.facebook.presto.operator.NestedLoopJoinPages,com.facebook.presto.operator.NestedLoopJoinPages> cannot be converted to com.google.common.base.Function<? super I,? extends O>))
[ERROR] /Users/wxie/Code/presto-all/presto/presto-main/src/main/java/com/facebook/presto/util/Threads.java:[62,27] cannot find symbol
[ERROR] symbol:   method get(com.google.common.util.concurrent.SettableFuture<java.lang.Boolean>,int,java.util.concurrent.TimeUnit,java.lang.Class<java.lang.Exception>)
[ERROR] location: class com.google.common.util.concurrent.Futures
...

Will check if it's an issue with the current airbase pom.xml .

wenleix · 2017-01-04T00:07:01Z

The guava is a separate issue and will be fixed by prestodb/presto#6995

findepi · 2018-06-20T09:19:00Z

@wenleix any plans? Can we close prestodb/presto#6655 ?

wenleix · 2018-06-21T00:17:43Z

@electrum : Any suggestions? Thanks!

electrum · 2018-06-21T02:53:11Z

Should we add properties for this? That would allow running tests multiple times for different locales. Otherwise, I’m fine to merge this. Please rebase and add CHANGES.

findepi · 2018-06-21T04:51:46Z

It think it should remain possible to run tests with different locales. For example, we could want to run CLI or JDBC tests with different locales.

ilfrin · 2018-09-10T12:18:03Z

@wenleix is there anything blocking from merging this and releasing a new version?

electrum · 2018-09-10T15:18:42Z

Thanks for the reminder. I’ll merge and release when I arrive at the office.

electrum · 2018-09-10T18:56:07Z

Chatted with @wenleix and he's going to update it. I also wanted to know if it could use <systemPropertyVariables> rather than -D arguments.

ilfrin · 2018-09-13T08:16:00Z

@electrum this is great, lets get this in.
cc @wenleix

thank you!

wenleix · 2018-10-14T00:00:09Z

@electrum : Rebased. Thanks!

findepi · 2018-10-14T15:34:52Z

CHANGES.md

@@ -1,3 +1,6 @@
+Airbase 85
+* Set the JVM locale fix to en-US when running tests


Use en-US locale when running Surefire tests.

electrum · 2018-10-15T23:47:25Z

CHANGES.md

@@ -1,3 +1,6 @@
+Airbase 85
+* Set the JVM locale fix to en-US when running tests


Nit: add newline after version header

findepi · 2018-11-25T22:03:13Z

I am happy to see this approved. @wenleix could you please rebase?

wenleix · 2018-11-27T09:51:00Z

@findepi , @electrum : Done rebase. thanks!

martint · 2018-11-27T15:28:36Z

CHANGES.md

@@ -3,6 +3,7 @@ Airbase 89
 * Dependency updates:
  - validation-api 2.0.1 (from 1.1.0)
  - BVal 2.0.0 (from 1.1.1)
+* Set the JVM locale fix to en-US when running Surefire tests.


Did you mean to leave the word “fix” there? It doesn’t sound right.

"...fixed to en-US..." ?

I think it should just say "Set the default JVM local for Surefire tests to en-US. It can be customized via the air.test.language and air.test.region properties".

Thanks @martint . Addressed.

This avoids different exception messages under different system languages.

wenleix · 2018-12-04T17:16:26Z

@electrum : Can you merge the PR ? Thanks!

findepi approved these changes Mar 5, 2017

View reviewed changes

findepi reviewed Oct 14, 2018

View reviewed changes

findepi mentioned this pull request Oct 15, 2018

Postgres connector tests started from IDE are locale-dependent prestodb/presto#9313

Closed

wenleix changed the title ~~Set the JVM locale fix to en-US when running tests.~~ Set the JVM locale fix to en-US when running tests Oct 15, 2018

electrum approved these changes Oct 15, 2018

View reviewed changes

findepi mentioned this pull request Oct 29, 2018

Some test do fail due to translated Exception.getMessage prestodb/presto#6655

Closed

martint reviewed Nov 27, 2018

View reviewed changes

Set the JVM locale fix to en-US when running tests

c8f6a41

This avoids different exception messages under different system languages.

martint merged commit 6b67ab2 into airlift:master Dec 4, 2018

wenleix deleted the surefire-locale branch December 5, 2018 05:05

findepi mentioned this pull request May 25, 2022

Fix the way locale information is passed to Surefire #315

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set the JVM locale fix to en-US when running tests #98

Set the JVM locale fix to en-US when running tests #98

wenleix commented Dec 24, 2016

wenleix commented Dec 24, 2016

wenleix commented Jan 4, 2017

findepi commented Jun 20, 2018

wenleix commented Jun 21, 2018

electrum commented Jun 21, 2018

findepi commented Jun 21, 2018 via email

ilfrin commented Sep 10, 2018

electrum commented Sep 10, 2018 via email

electrum commented Sep 10, 2018

ilfrin commented Sep 13, 2018

wenleix commented Oct 14, 2018

findepi Oct 14, 2018

electrum Oct 15, 2018

findepi commented Nov 25, 2018

wenleix commented Nov 27, 2018

martint Nov 27, 2018

findepi Nov 27, 2018

wenleix Nov 29, 2018

martint Nov 29, 2018 •

edited

Loading

wenleix Nov 29, 2018

wenleix commented Dec 4, 2018 •

edited

Loading

		@@ -1,3 +1,6 @@
		Airbase 85
		* Set the JVM locale fix to en-US when running tests

Set the JVM locale fix to en-US when running tests #98

Set the JVM locale fix to en-US when running tests #98

Conversation

wenleix commented Dec 24, 2016

wenleix commented Dec 24, 2016

wenleix commented Jan 4, 2017

findepi commented Jun 20, 2018

wenleix commented Jun 21, 2018

electrum commented Jun 21, 2018

findepi commented Jun 21, 2018 via email

ilfrin commented Sep 10, 2018

electrum commented Sep 10, 2018 via email

electrum commented Sep 10, 2018

ilfrin commented Sep 13, 2018

wenleix commented Oct 14, 2018

findepi Oct 14, 2018

Choose a reason for hiding this comment

electrum Oct 15, 2018

Choose a reason for hiding this comment

findepi commented Nov 25, 2018

wenleix commented Nov 27, 2018

martint Nov 27, 2018

Choose a reason for hiding this comment

findepi Nov 27, 2018

Choose a reason for hiding this comment

wenleix Nov 29, 2018

Choose a reason for hiding this comment

martint Nov 29, 2018 • edited Loading

Choose a reason for hiding this comment

wenleix Nov 29, 2018

Choose a reason for hiding this comment

wenleix commented Dec 4, 2018 • edited Loading

martint Nov 29, 2018 •

edited

Loading

wenleix commented Dec 4, 2018 •

edited

Loading