-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK 22-23 compatiblity with reproducible builds #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to override them in a child project without a need for an airbase release which in turns makes it possible to test new versions or upgrade plugins without changes to the airbase.
wendigo
force-pushed
the
serafin/bunch-of-updates
branch
from
April 25, 2024 19:04
a657175
to
4e312b0
Compare
wendigo
force-pushed
the
serafin/bunch-of-updates
branch
from
April 25, 2024 19:50
4e312b0
to
61e4769
Compare
@electrum PTAL. I've dropped opentelemetry updates from the previous PR. These are problematic right now in Trino (deprecations) |
Which means that you can run build multiple times for a given commit and it will always produce the same, binary identical artifacts.
wendigo
force-pushed
the
serafin/bunch-of-updates
branch
from
April 25, 2024 20:44
61e4769
to
b0c25de
Compare
Verified reproducible build with Trino:
It works 🎉 |
Added a checkstyle rules configuration to allow for |
cc @electrum PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.